Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6796 #6984

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

rodyoukai
Copy link
Contributor

Fix #6796

Captura desde 2024-12-11 15-06-26

Now the constrast in "Add another" buton is acceptable

Copy link

github-actions bot commented Dec 11, 2024

Test Results

    13 files  ±0      13 suites  ±0   2h 46m 6s ⏱️ - 5m 9s
 6 833 tests +1   6 533 ✅ ±0  299 💤 ±0  1 ❌ +1 
18 101 runs  ±0  17 623 ✅  - 1  477 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 131b88a. ± Comparison against base commit 5b03f59.

This pull request removes 366 and adds 367 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f1dee2c75a0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fd7baffec60>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fed1e19c6d0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f1decb548a0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fd7b396f3d8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fed21bcaa00>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 0a7a0ecf-5a43-4cb0-ad08-cb47adfcb322
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 08d73801-d28a-49d0-8c4f-ee4604573baa
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 0ed58e92-069e-4b1e-806e-d7df3162ea01
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 63f2d00f-1e8b-4cfe-854d-e6fcb00b7047
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f1168c22d08>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f56026a3358>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f88ca91f000>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f1169a411a0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f56027b30e0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f88cad5caa0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: a3bba834-7d0f-45a4-a863-270a52ef6229
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 05da1ca2-9475-4b7d-a1d6-c8cffdf4c143
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 8128269c-2242-40d9-b7e8-108c62b7fa2e
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 15d78335-2f58-4fce-9ec0-a9419214c15d
…

♻️ This comment has been updated with latest results.

@mathewjordan mathewjordan removed their request for review December 12, 2024 15:52
@mathewjordan
Copy link
Member

Hi @rodyoukai -- I think you may have requested review from the wrong user.

Best -- Mat

@rodyoukai
Copy link
Contributor Author

Hi @mathewjordan, Im so sorry, I took the suggestion of GitHub, my apologies

…-meet-WCAG-AA-minimum-color-contrast-requirements
@rodyoukai rodyoukai requested a review from dlpierce December 13, 2024 18:02
Copy link
Member

@orangewolf orangewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned about unintended styling changes here. .btn-link is used in several other places. Could we scope it to .btn-link.add so it only affects this one button or can you confirm you looked at the collections and file versioning usages and that they also tolerate this change?

@rodyoukai
Copy link
Contributor Author

Hi @orangewolf, I have applied the changes you suggested to the code.

…-meet-WCAG-AA-minimum-color-contrast-requirements
…-meet-WCAG-AA-minimum-color-contrast-requirements
@rodyoukai rodyoukai requested a review from orangewolf January 10, 2025 19:14
…-meet-WCAG-AA-minimum-color-contrast-requirements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links on New User Collection page to not meet WCAG AA minimum color contrast requirements
3 participants