Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Support for more data types #1

Open
D063520 opened this issue Oct 14, 2019 · 2 comments
Open

Support for more data types #1

D063520 opened this issue Oct 14, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@D063520
Copy link

D063520 commented Oct 14, 2019

Hi,

do you plan to implement these:

if data_type in ["monolingualtext", "string"]:
    return py_wb.StringValue().unmarshal(data_value)
elif data_type == "commonsMedia":
    raise NotImplementedError  # TODO
elif data_type == "external-id":
    return py_wb.ExternalId().unmarshal(data_value)
elif data_type == "geo-shape":
    raise NotImplementedError  # TODO
elif data_type == "globe-coordinate":
    return py_wb.GeoLocation().unmarshal(data_value)
elif data_type == "math":
    raise NotImplementedError  # TODO
elif data_type == "quantity":
    return py_wb.Quantity().unmarshal(data_value)
elif data_type == "tabular-data":
    raise NotImplementedError  # TODO
elif data_type == "time":
    raise NotImplementedError  # TODO
elif data_type == "url":
    raise NotImplementedError  # TODO
elif data_type == "wikibase-form":
    raise NotImplementedError  # TODO
elif data_type == "wikibase-lexeme":
    raise NotImplementedError  # TODO
elif data_type == "wikibase-sense":
    raise NotImplementedError  # TODO

Salut
D063520

@samuelmeuli
Copy link
Owner

samuelmeuli commented Oct 14, 2019

Hi @D063520,

I'm not working with Wikibase anymore and therefore not planning on adding features to this library myself. If anyone else wants to implement these data types, I'd be happy to have a look at PRs though :)

The relevant code can be found in data_type.py.

@D063520
Copy link
Author

D063520 commented Oct 14, 2019

Hi,

thank you for the quick response .... I will see how much I needed it ...

Merci
D063520

@samuelmeuli samuelmeuli added the enhancement New feature or request label Oct 14, 2019
@samuelmeuli samuelmeuli changed the title Non implemented datatypes Support for more data types Feb 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants