Allow interned values as tracked function arguments #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
MichaReiser
commented
Jul 20, 2024
| @@ -93,6 +93,12 @@ macro_rules! setup_interned_struct { | |||
| } | |||
| } | |||
|
|
|||
| impl<$db_lt> $zalsa::LookupId<$db_lt> for $Struct<$db_lt> { | |||
| fn lookup_id(id: salsa::Id, db: &$db_lt dyn $zalsa::Database) -> Self { | |||
| $Configuration::ingredient(db).interned_value(id) | |||
There was a problem hiding this comment.
Not 100% sure about this but it compiles and the test passes ;)
nikomatsakis
approved these changes
Jul 22, 2024
| @@ -93,6 +93,12 @@ macro_rules! setup_interned_struct { | |||
| } | |||
| } | |||
|
|
|||
| impl<$db_lt> $zalsa::LookupId<$db_lt> for $Struct<$db_lt> { | |||
| fn lookup_id(id: salsa::Id, db: &$db_lt dyn $zalsa::Database) -> Self { | |||
| $Configuration::ingredient(db).interned_value(id) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the second part of #521 where tracked functions didn't accept interned values