Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsoundness: Tracked-fields with no_eq can store references #681

Open
MichaReiser opened this issue Feb 8, 2025 · 0 comments
Open

Unsoundness: Tracked-fields with no_eq can store references #681

MichaReiser opened this issue Feb 8, 2025 · 0 comments

Comments

@MichaReiser
Copy link
Contributor

#[salsa::tracked]
pub(crate) struct Expression<'db> {

    #[no_eq]
    pub(crate) test: &'db str,

}

This compiles when it should not. We still need to enforce the Update trait for test or, have a dedicated trait (because implementing Update is a bit non-sensical)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant