277 fake jira issue generator without jiragiler

[anthonyjlau]

Created 2 new files, jira-new.R and test-jira-new.R, to make a new fake data generator without the edits that JirAgileR makes to the data.

[carlosparadis]

@anthonyjlau Your code should be added to R/jira.R. The files are organized so to reflect modules in the code. Let's iterate over the specification on the task issue on code organization.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.56%. Comparing base (2bc8d14) to head (917ba35).
Report is 1 commits behind head on master.

❗ Current head 917ba35 differs from pull request most recent head 43638ac. Consider uploading reports for the commit 43638ac to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
- Coverage   39.79%   38.56%   -1.23%     
==========================================
  Files          20       20              
  Lines        3091     3101      +10     
==========================================
- Hits         1230     1196      -34     
- Misses       1861     1905      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[anthonyjlau]

@carlosparadis My R-CMD-check is failing because create_base_info and create_ext_info is in a documentation object but I am not sure what this documentation object is in.

The warning is on line 548:
https://github.com/sailuh/kaiaulu/actions/runs/8027363702/job/21931238840?pr=280#step:10:548

[carlosparadis]

@anthonyjlau #280 (comment)

Did you recompile the documentation like the workflow on how the PR should be made suggests?

[anthonyjlau]

@carlosparadis As you said, I needed to recompile the documentation. However, now I get an error saying:

✖ `make_jira_issue` masks `kaiaulu::make_jira_issue()`.
✖ `make_jira_issue_tracker` masks `kaiaulu::make_jira_issue_tracker()`.
ℹ Did you accidentally source a file rather than using `load_all()`?

Also, when I try to build Kaiaulu (ie. hitting the Install button at the top) I get:

The following objects are masked _by_ ‘.GlobalEnv’:
    make_jira_issue, make_jira_issue_tracker

I did not change any documentation in R/jira.R and I am not sure what this means. Help on this would be appreciated!

[ian-lastname]

Looks alright as far as I can see.

[carlosparadis]

@anthonyjlau

You need to address the RMD-Check not passing before I can review.

[anthonyjlau]

When I was merging the Kaiaulu master branch with my origin master branch, I accidently pushed changes on to my master branch that was not intended. In order to solve this, I did git checkout <commit hash> where the commit hash was the one for the previous commit. Then, I forced pushed that commit using git push origin master -f. This required me to setup an SSH key with GitHub. I followed this website to make a SSH key and this website to add it to my account. After doing that, I was able to fix my master branch on my origin and do the merge.

Leaving this here so there is some documentation of this.

[carlosparadis]

I have not done a test run on my local machine yet, but please address these first before then.

[carlosparadis]

After everything else is modified, I will let you know when to uncoment these.

[carlosparadis]

Working on this PR next. Please do not commit to your fork.

[carlosparadis]

Check still fails due to reference to a function that doesn't exist (the downloader).

[carlosparadis]

Checks will still fail here due to the reference to the downloader, but the Fake data generator worked fine with the parser. One thing that was missing was the removal of the examples folder. That has also been addressed. Parser can now be unit tested and tests pass. Only thing missing is the Downloader, at which point all checks should pass.

The Notebook should also be updated on the Downloader to reflect the new setup.