Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node from 23.1-alpine to 23.3-alpine #97

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Bump node from 23.1-alpine to 23.3-alpine #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
10bb5ad
Bump node from 23.1-alpine to 23.3-alpine
dependabot[bot] Nov 25, 2024
ec71d4e
chore: ci workflow trigger
saidsef Nov 27, 2024
5241e82
fix: k8s test job set K8s version
saidsef Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,12 +92,14 @@ jobs:
steps:
- name: Create k8s Kind Cluster
uses: helm/kind-action@v1.10.0
with:
verbosity: "10"
kubectl_version: "v1.29.3"
- name: Checkout
uses: actions/checkout@v4
- name: Run K8s test
run: |
kubectl cluster-info
kubectl version --short
kubectl version
export NS=`cat deployment/kustomization.yml | grep namespace | awk '{ print $2 }'`
if [ -z "$NS" ]; then
export NS='data'
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM docker.io/node:23.1-alpine
FROM docker.io/node:23.3-alpine

LABEL maintainer="Said Sef <saidsef@gmail.com> (saidsef.co.uk/)"
LABEL "uk.co.saidsef.aws-kinesis"="Said Sef Associates Ltd"
Expand All @@ -6,16 +6,16 @@

ARG PORT=""

ENV AWS_DEFAULT_REGION "eu-west-1"

Check warning on line 9 in Dockerfile

View workflow job for this annotation

GitHub Actions / build

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV CREATESTREAMMS ${CREATESTREAMMS:-50}

Check warning on line 10 in Dockerfile

View workflow job for this annotation

GitHub Actions / build

Variables should be defined before their use 

UndefinedVar: Usage of undefined variable '$CREATESTREAMMS'
More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/
ENV DELETESTREAMMS ${DELETESTREAMMS:-50}

Check warning on line 11 in Dockerfile

View workflow job for this annotation

GitHub Actions / build

Variables should be defined before their use 

UndefinedVar: Usage of undefined variable '$DELETESTREAMMS'
More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/

Check warning on line 11 in Dockerfile

View workflow job for this annotation

GitHub Actions / build

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV KPATH ${KPATH:-/data}
ENV NODE_ENV production
ENV NODE_PENDING_DEPRECATION 1

Check warning on line 14 in Dockerfile

View workflow job for this annotation

GitHub Actions / build

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV NPM_CONFIG_CACHE /data
ENV PORT ${PORT:-4567}
ENV SHARDLIMIT ${SHARDLIMIT:-50}

Check warning on line 17 in Dockerfile

View workflow job for this annotation

GitHub Actions / build

Variables should be defined before their use 

UndefinedVar: Usage of undefined variable '$SHARDLIMIT'
More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/

Check warning on line 17 in Dockerfile

View workflow job for this annotation

GitHub Actions / build

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV UPDATESTREAMMS ${UPDATESTREAMMS:-50}

Check warning on line 18 in Dockerfile

View workflow job for this annotation

GitHub Actions / build

Variables should be defined before their use 

UndefinedVar: Usage of undefined variable '$UPDATESTREAMMS'
More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/

Check warning on line 18 in Dockerfile

View workflow job for this annotation

GitHub Actions / build

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

WORKDIR /data

Expand All @@ -31,5 +31,5 @@

HEALTHCHECK --interval=60s --timeout=10s CMD nc -zvw3 127.0.0.1 4567 || exit 1

CMD ["/usr/local/bin/kinesalite", "--port", ${PORT}, "--path", ${KPATH}, "--shardLimit", ${SHARDLIMIT}, "--createStreamMs", ${CREATESTREAMMS}, "--deleteStreamMs", ${DELETESTREAMMS}]

Check warning on line 34 in Dockerfile

View workflow job for this annotation

GitHub Actions / build

JSON arguments recommended for ENTRYPOINT/CMD to prevent unintended behavior related to OS signals 

JSONArgsRecommended: JSON arguments recommended for CMD to prevent unintended behavior related to OS signals
More info: https://docs.docker.com/go/dockerfile/rule/json-args-recommended/
ENTRYPOINT ["/usr/local/bin/kinesalite"]