Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix timers typo #502

Closed
wants to merge 2 commits into from
Closed

core: fix timers typo #502

wants to merge 2 commits into from

Conversation

topelinux
Copy link
Contributor

fix clearInterval typo

@saghul
Copy link
Owner

saghul commented Apr 30, 2024

🤦

@saghul
Copy link
Owner

saghul commented Apr 30, 2024

Can you regenerate the bytecode? make js and commit the result.

@topelinux
Copy link
Contributor Author

Can you regenerate the bytecode? make js and commit the result.

done, please review again.

@saghul
Copy link
Owner

saghul commented Apr 30, 2024

Looks like there is a mismatch. You can try again by making sure to use Node 20 or I can help later today!

@topelinux
Copy link
Contributor Author

Looks like there is a mismatch. You can try again by making sure to use Node 20 or I can help later today!

i have try with node 20.5.1, same result(make js no different with git status), maybe there is something i missed, please help to commit on your side.

@saghul
Copy link
Owner

saghul commented May 6, 2024

Created #509 since I cannot push to your repo. The commit author is still you.

@saghul saghul closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants