console implementation according to standard

[lal12]

Implementing console according to standard.

Still a bunch of test cases missing, but otherwise complete.

Any thoughts?

[lal12]

E.g. would be nice to expose the createConsole function for customization.

[saghul]

Great work! Left some comments.

[lal12]

Added tests from wpt and added some changes to fulfill those and match some nodejs behavior. In some places wpt tests seemed to be wrong, and neither browser nor nodejs acted accordingly (but differently from each other), there I used nodejs behavior.

JS console standards seems to be oddly wild 😆

Diverging from spec are the following things:

• countReset is resetting instead setting to 0. MDN leaves it open, NodeJS does this too, Chrome+FF follow spec, though FF also prints label: 0
• added options argument to Logger, to allow for some specific warning handling to better match nodejs behavior

I also copied the code from util package and moved it here to add missing features as defined in console spec. Though alternatively we could extend the alteady existing util patch.

[saghul]

I also copied the code from util package and moved it here to add missing features as defined in console spec. Though alternatively we could extend the alteady existing util patch.

Good call, I was thingking about eventually doing that, so thanks for going in that direction.

[saghul]

This looks great! Are you going to be adding anything else, or should we merge?

[lal12]

This looks great! Are you going to be adding anything else, or should we merge?

Just pushed the types for createConsole. I have nothing else to add. The only thing I was wondering if there is a better way for registering createConsole (see console.js:327)

[saghul]

The only thing I was wondering if there is a better way for registering createConsole (see console.js:327)

It looks odd indeed. I'll take a look.

[saghul]

Excellent work @lal12 !