-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add arm64 macOS to the testing matrix #483
Conversation
@lal12 The sprintf test fails on arm64 macOS. Got any idea why that would be? I can repro locally too. |
It seems libffi does not officially support arm64-darwin. It seems to be stale WIP (libffi/libffi#621) There seem to be to options though:
Everything at first glance for now. |
Or disabling libffi for this scenario by default in CMAKE. |
Just tested with the newest libffi release, now it's a SEGFAULT instead. (https://github.com/lal12/txiki.js/actions/runs/8643918438/job/23697940801) Hard to debug without a bare metal. Tried scaleway to book one online, but they didn't let me book it. |
Can we try this? |
Added a commit which links with the system provided libffi, but it segfaults 🙃 |
I fiddled around a bit. My suspicion is that all is fine with libffi, just that sprintf and dirent have different definitions on MacOS for arm. If I comment both test parts out it works fine. I think moving all tests into our own binary testlib (as one test already is), is more robust (also considering the windows exceptions). |
I see. THe
Ah, the ffi-test-lib.c file. Yeah that makes sense! Feel free to do that change when you've got the time! |
Yep, you're right. At least sprintf has a wrong call in test-ffi.js. Interesting that it works on any other platform. |
No description provided.