fix invalid memory writes #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lal12
force-pushed
the
fix-ffi-invalid-writes
branch
from
d72530b to
9ec23bc
Compare
|
Added some windows build fixes. |
|
Thank you! Can you please flip the mimalloc build flag to default to on? That's what triggered the failures. This flag: Line 47 in 9c4ea9c |
saghul
reviewed
Apr 9, 2024
saghul
force-pushed
the
fix-ffi-invalid-writes
branch
from
118bf00 to
d95479f
Compare
saghul
force-pushed
the
fix-ffi-invalid-writes
branch
from
d95479f to
af1ea20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #461