Skip to content

Commit b8c9bb6

Browse files
committed
core: refactor global nitialize
Initialize curl there, while we're at it.
1 parent ae63e78 commit b8c9bb6

File tree

4 files changed

+5
-19
lines changed

4 files changed

+5
-19
lines changed

src/cli.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828

2929

3030
int main(int argc, char **argv) {
31-
TJS_SetupArgs(argc, argv);
31+
TJS_Initialize(argc, argv);
3232

3333
TJSRuntime *qrt = TJS_NewRuntime();
3434
CHECK_NOT_NULL(qrt);

src/curl-utils.c

-14
Original file line numberDiff line numberDiff line change
@@ -31,19 +31,7 @@
3131
"txiki.js/" STRINGIFY(TJS_VERSION_MAJOR) "." STRINGIFY(TJS_VERSION_MINOR) "." STRINGIFY(TJS_VERSION_PATCH) \
3232
TJS_VERSION_SUFFIX
3333

34-
static uv_once_t curl__init_once = UV_ONCE_INIT;
35-
36-
static void tjs__curl_init_once(void) {
37-
curl_global_init(CURL_GLOBAL_ALL);
38-
}
39-
40-
static void tjs__curl_init(void) {
41-
uv_once(&curl__init_once, tjs__curl_init_once);
42-
}
43-
4434
CURL *tjs__curl_easy_init(CURL *curl_h) {
45-
tjs__curl_init();
46-
4735
if (curl_h == NULL)
4836
curl_h = curl_easy_init();
4937

@@ -261,8 +249,6 @@ CURLM *tjs__get_curlm(JSContext *ctx) {
261249
CHECK_NOT_NULL(qrt);
262250

263251
if (!qrt->curl_ctx.curlm_h) {
264-
tjs__curl_init();
265-
266252
CURLM *curlm_h = curl_multi_init();
267253
curl_multi_setopt(curlm_h, CURLMOPT_SOCKETFUNCTION, curl__handle_socket);
268254
curl_multi_setopt(curlm_h, CURLMOPT_SOCKETDATA, qrt);

src/tjs.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ void TJS_DefaultOptions(TJSRunOptions *options);
4242
TJSRuntime *TJS_NewRuntime(void);
4343
TJSRuntime *TJS_NewRuntimeOptions(TJSRunOptions *options);
4444
void TJS_FreeRuntime(TJSRuntime *qrt);
45-
void TJS_SetupArgs(int argc, char **argv);
45+
void TJS_Initialize(int argc, char **argv);
4646
JSContext *TJS_GetJSContext(TJSRuntime *qrt);
4747
TJSRuntime *TJS_GetRuntime(JSContext *ctx);
4848
int TJS_Run(TJSRuntime *qrt);

src/vm.c

+3-3
Original file line numberDiff line numberDiff line change
@@ -282,11 +282,11 @@ void TJS_FreeRuntime(TJSRuntime *qrt) {
282282
free(qrt);
283283
}
284284

285-
void TJS_SetupArgs(int argc, char **argv) {
285+
void TJS_Initialize(int argc, char **argv) {
286+
curl_global_init(CURL_GLOBAL_ALL);
287+
286288
tjs__argc = argc;
287289
tjs__argv = uv_setup_args(argc, argv);
288-
if (!tjs__argv)
289-
tjs__argv = argv;
290290
}
291291

292292
JSContext *TJS_GetJSContext(TJSRuntime *qrt) {

0 commit comments

Comments
 (0)