Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use NATS #8118

Open
wants to merge 114 commits into
base: master
Choose a base branch
from
Open

use NATS #8118

wants to merge 114 commits into from

Conversation

williamstein
Copy link
Contributor

@williamstein williamstein commented Jan 13, 2025

This is purely some proofs of concept and likely will never be merged.

This works and is serious.

…rowser client

- the key idea is a "bearer JWT".  The bearer part took a while to
  understand
… starts (and can also be remotely terminated)
…nitial load vastly faster via a "clever trick"
… subtle issues that would result in bugs and performance problems
- this breaks some things in crm editor still, and the old code is still there too
- awkward to do with no persistent connection to a single hub (which
  we will not have with nats)
- most of the data is not relevant anymore
- most code ancient coffeescript
- package itself was several versions old
- i never looked at this data even once
- deleted all the old "legacy api key" code, which was coffeescript or
  autotranslated typescript, and probably dangerous.  This makes cocalc
  more secure.
- deeply entangled in there was some tracking of sign-ins for SSO.  I
  just deleted all of that.  I never look at those anyways and we could
  add back something better if it matters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant