-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use NATS #8118
Open
williamstein
wants to merge
114
commits into
master
Choose a base branch
from
nats
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
use NATS #8118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- it just works fine, even with nextjs around and a base path, etc.! :-)
…rowser client - the key idea is a "bearer JWT". The bearer part took a while to understand
…ccess to project subjects
…how it goes - not done
…ke a pit of failure.
… starts (and can also be remotely terminated)
…try to implement cursors (not done)
…nitial load vastly faster via a "clever trick"
… subtle issues that would result in bugs and performance problems
- this breaks some things in crm editor still, and the old code is still there too
… at default and easy to disable/enable
- awkward to do with no persistent connection to a single hub (which we will not have with nats) - most of the data is not relevant anymore - most code ancient coffeescript - package itself was several versions old - i never looked at this data even once
- deleted all the old "legacy api key" code, which was coffeescript or autotranslated typescript, and probably dangerous. This makes cocalc more secure. - deeply entangled in there was some tracking of sign-ins for SSO. I just deleted all of that. I never look at those anyways and we could add back something better if it matters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is purely some proofs of concept and likely will never be merged.This works and is serious.