Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example: Safe + 4337 + Passkeys example application #217

Merged
merged 15 commits into from
Jan 24, 2024
Merged

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Jan 22, 2024

This PR adds an example application where a Safe with a passkey owner is deployed and minting an NFT. Implements #188 and #187

Demo recording:
https://www.loom.com/share/c44946ad137341daa9be08dce07cd886

Testing the application:

  1. Follow the instructions in the README

@coveralls
Copy link

coveralls commented Jan 22, 2024

Pull Request Test Coverage Report for Build 7613944713

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 82.738%

Totals Coverage Status
Change from base Build 7608599900: 0.4%
Covered Lines: 101
Relevant Lines: 110

💛 - Coveralls

@mmv08 mmv08 force-pushed the feat/webauth-poc-app branch from 95c615e to 596d62e Compare January 22, 2024 11:48
@mmv08 mmv08 marked this pull request as ready for review January 22, 2024 11:50
@mmv08 mmv08 requested a review from a team as a code owner January 22, 2024 11:50
@mmv08 mmv08 requested review from rmeissner, nlordell, akshay-ap and remedcu and removed request for a team January 22, 2024 11:50
@mmv08 mmv08 force-pushed the feat/webauth-poc-app branch from 596d62e to 4fdefa7 Compare January 22, 2024 11:57
@nlordell
Copy link
Collaborator

No contracts are verified 😞. Sorry!

I chuckled.

@@ -7,6 +7,10 @@ This repository contains a collection of modules for the [Safe Smart Account](ht
- [4337 Module](./modules/4337)
- [Allowance Module](./modules/allowances)

## Examples

- [Safe + 4337 + Passkeys](./examples/safe-4337-passkeys)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR, but I feel like the gas metering project should also be moved here. Maybe there is a more general directory name to “examples” that would fit both workspace packages...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@nlordell nlordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few small nits (disclaimer: I didn’t look too closely at the FE code). It just occurred to me, but should this live in 5afe org?

@mmv08 mmv08 force-pushed the feat/webauth-poc-app branch from 6dd58d5 to 08b2fbb Compare January 22, 2024 16:03
@mmv08 mmv08 force-pushed the feat/webauth-poc-app branch from 08b2fbb to 261758c Compare January 22, 2024 16:03
@mmv08 mmv08 requested a review from nlordell January 22, 2024 17:53
@mmv08 mmv08 merged commit 81aa0e4 into main Jan 24, 2024
8 checks passed
@mmv08 mmv08 deleted the feat/webauth-poc-app branch January 24, 2024 09:00
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants