-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example: Safe + 4337 + Passkeys example application #217
Conversation
Pull Request Test Coverage Report for Build 7613944713
💛 - Coveralls |
95c615e
to
596d62e
Compare
596d62e
to
4fdefa7
Compare
I chuckled. |
@@ -7,6 +7,10 @@ This repository contains a collection of modules for the [Safe Smart Account](ht | |||
- [4337 Module](./modules/4337) | |||
- [Allowance Module](./modules/allowances) | |||
|
|||
## Examples | |||
|
|||
- [Safe + 4337 + Passkeys](./examples/safe-4337-passkeys) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR, but I feel like the gas metering project should also be moved here. Maybe there is a more general directory name to “examples” that would fit both workspace packages...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @remedcu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few small nits (disclaimer: I didn’t look too closely at the FE code). It just occurred to me, but should this live in 5afe
org?
6dd58d5
to
08b2fbb
Compare
… env sample file, remove leftover comments
08b2fbb
to
261758c
Compare
This PR adds an example application where a Safe with a passkey owner is deployed and minting an NFT. Implements #188 and #187
Demo recording:
https://www.loom.com/share/c44946ad137341daa9be08dce07cd886
Testing the application: