Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor: Update vendored FCL code #192

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Vendor: Update vendored FCL code #192

merged 1 commit into from
Dec 18, 2023

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Dec 18, 2023

This PR:

@mmv08 mmv08 force-pushed the feat/update-vendored-fc branch from c677e1a to 241f93a Compare December 18, 2023 15:16
@mmv08 mmv08 force-pushed the feat/update-vendored-fc branch from 241f93a to e17516a Compare December 18, 2023 15:17
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7250088412

  • 0 of 6 (0.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 13.547%

Changes Missing Coverage Covered Lines Changed/Added Lines %
4337/contracts/test/FCL/FCL_ecdsa_utils.sol 0 1 0.0%
4337/contracts/test/FCL/FCL_Webauthn.sol 0 2 0.0%
4337/contracts/test/FCL/FCL_elliptic.sol 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
4337/contracts/test/FCL/FCL_elliptic.sol 1 0.0%
Totals Coverage Status
Change from base Build 7207149151: -0.2%
Covered Lines: 33
Relevant Lines: 282

💛 - Coveralls

@mmv08 mmv08 marked this pull request as ready for review December 18, 2023 15:20
@mmv08 mmv08 requested a review from a team as a code owner December 18, 2023 15:20
@mmv08 mmv08 requested review from rmeissner, nlordell, akshay-ap and remedcu and removed request for a team December 18, 2023 15:20
Copy link
Member

@remedcu remedcu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏾

@mmv08 mmv08 merged commit 0fbb33a into master Dec 18, 2023
4 checks passed
@mmv08 mmv08 deleted the feat/update-vendored-fc branch December 18, 2023 17:27
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants