diff --git a/.ansible-lint b/.ansible-lint new file mode 100644 index 0000000..70fa7f2 --- /dev/null +++ b/.ansible-lint @@ -0,0 +1,16 @@ +warn_list: + - command-instead-of-module + - no-changed-when + - var-spacing + - ignore-errors + - risky-file-permissions + - empty-string-compare + - risky-shell-pipe + - yaml + - meta-no-info + - var-naming + - literal-compare + - package-latest + +skip_list: + - fqcn-builtins diff --git a/.github/workflows/ansible-lint.yml b/.github/workflows/ansible-lint.yml new file mode 100644 index 0000000..d8b52a3 --- /dev/null +++ b/.github/workflows/ansible-lint.yml @@ -0,0 +1,33 @@ +name: ansible-lint + +on: + push: + branches: + - development + pull_request: + branches: + - development + - master + +jobs: + build: + runs-on: ubuntu-latest + strategy: + matrix: + python-version: ["3.6", "3.7", "3.8", "3.9", "3.10"] + steps: + - uses: actions/checkout@v2 + - name: Set up Python ${{ matrix.python-version }} + uses: actions/setup-python@v2 + with: + python-version: ${{ matrix.python-version }} + - name: Install dependencies + run: | + python -m pip install --upgrade pip + pip install ansible ansible-lint + - name: Analysing all playbooks + run: | + ansible-lint install/*.yml -x 303,701,601,206,602,403,301,502,306 -v + - name: Analysing all playbook roles + run: | + ansible-lint install/roles/*/*/*.yml -x 303,701,601,206,602,403,301,502,306 -v diff --git a/install/roles/curator/tasks/main.yml b/install/roles/curator/tasks/main.yml index e0cb760..debe1b4 100644 --- a/install/roles/curator/tasks/main.yml +++ b/install/roles/curator/tasks/main.yml @@ -47,7 +47,8 @@ # Runs cron job to cleanup indices every weekday. # you should adjust this to your needs -- cron: +- name: Curator Cleanup Cronjob + cron: name: Curator run weekday: '*' minute: 0 diff --git a/install/roles/packetbeat/meta/main.yml b/install/roles/packetbeat/meta/main.yml index 8b3cfde..7ae66cd 100644 --- a/install/roles/packetbeat/meta/main.yml +++ b/install/roles/packetbeat/meta/main.yml @@ -1,3 +1,3 @@ --- dependencies: - - { role: elk_client } \ No newline at end of file + - { role: elk_client } diff --git a/meta/main.yml b/meta/main.yml index 03a68e9..8078fc6 100644 --- a/meta/main.yml +++ b/meta/main.yml @@ -1,5 +1,7 @@ galaxy_info: author: Will Foster (@sadsfae) + role_name: ansible_elk + namespace: sadsfae description: Playbook for setting up an ELK/EFK stack and clients. travis_status_url: https://travis-ci.org/sadsfae/ansible-elk.svg?branch=master issue_tracker_url: https://github.com/sadsfae/ansible-elk/issues diff --git a/tests/test-requirements.txt b/tests/test-requirements.txt index 6e50cd5..69191bd 100644 --- a/tests/test-requirements.txt +++ b/tests/test-requirements.txt @@ -2,4 +2,5 @@ ## ## pip install --requirement=test-requirements.txt ## +ansible ansible-lint