Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dubious change introduced to the debug driver in e74bb581252fd3fa130fbac57404b94bd780a707 #8

Open
HinTak opened this issue May 23, 2021 · 2 comments
Open

dubious change introduced to the debug driver in e74bb581252fd3fa130fbac57404b94bd780a707 #8

HinTak opened this issue May 23, 2021 · 2 comments

Comments

@HinTak
Copy link

HinTak commented May 23, 2021

Two lines were deleted in the debug driver:

-               urb->actual_length = 0;
-               *(u32 *)urb->transfer_buffer = 0;

see
e74bb58#r51194030

commit e74bb581252fd3fa130fbac57404b94bd780a707
Author: sadko4u <sadko4u@gmail.com>
Date:   Thu Jan 14 01:07:02 2021 +0300

    Added Scarlett 2i2 support

This seems to be wrongly removed.
HinTak added a commit to HinTak/sound-usb-dkms that referenced this issue May 23, 2021
@HinTak
Merging almost all of the debug code from https://github.com/sadko4u/…
899ad6a 
…focusrite-scarlett-backports

After this change, the code is identical to
97ab71438152ab4665005419fa131cf6d9958495:debug-drv/mixer_scarlett_gen2.c,
except for two items (and misc white-space changes):

b2b041c - the code here is correct

The diff sadko4u/focusrite-scarlett-backports#8 is dubious and
not in the production driver.
@HinTak HinTak mentioned this issue May 23, 2021
Closed
@sadko4u
Copy link
Owner

sadko4u commented May 25, 2021

That was my initiative to add these lines first. And then I've just removed them when found out that they are not necessary. Anyway, we can keep these lines to be more sure that data becomes cleaned up.

@HinTak
Copy link
Author

HinTak commented May 25, 2021

The removal appears in an unrelated commit (as far as the commit message description goes), and it also leaves the debug version and production different afterwards... Hence I decided it is a mistake.

HinTak added a commit to Focusrite-Scarlett-on-Linux/sound-usb-kernel-module that referenced this issue May 30, 2021
@HinTak
Merging almost all of the debug code from https://github.com/sadko4u/…
c36d741 
…focusrite-scarlett-backports

After this change, the code is identical to
97ab71438152ab4665005419fa131cf6d9958495:debug-drv/mixer_scarlett_gen2.c,
except for two items (and misc white-space changes):

b2b041c - the code here is correct

The diff sadko4u/focusrite-scarlett-backports#8 is dubious and
not in the production driver.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sadko4u @HinTak