Merge pull request #582 from yamamoto-febc/fix/v1/progress

Fixed progress termination process

Author: yamamoto-febc

pkg/cmd/core/command.go

@@ -376,7 +376,9 @@ func (c *Command) exec(ctx cli.Context, ids cli.ResourceContexts) (output.Conten
 		fn := c.Func
 		c.Func = func(ctx cli.Context, parameter interface{}) ([]interface{}, error) {
 			var results []interface{}
-			err := NewProgress(ctx).Exec(func() error {
+			progress := NewProgress(ctx)
+			defer progress.Close()
+			err := progress.Exec(func() error {
 				res, err := fn(ctx, parameter)
 				if err != nil {
 					return err

pkg/cmd/core/progress.go

@@ -94,7 +94,6 @@ func (p *Progress) msgFailed(err error) string {
 
 func (p *Progress) Start() {
 	p.doneCh = make(chan error)
-	defer close(p.doneCh)
 
 	ticker := time.NewTicker(p.duration)
 	defer ticker.Stop()
@@ -130,3 +129,7 @@ func (p *Progress) print(clr *color.Color, msg string) {
 	p.printer.Fprint(p.out, clr, msg)
 	p.printer.Fprint(p.out, color.New(color.Reset), "")
 }
+
+func (p *Progress) Close() {
+	close(p.doneCh)
+}