Skip to content

Commit

Permalink
Mark specs that are broken due to polyamorous as pending
Browse files Browse the repository at this point in the history
  • Loading branch information
Ray Zane committed Apr 25, 2018
1 parent d512964 commit 34e07ba
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 0 deletions.
12 changes: 12 additions & 0 deletions spec/integration/joining_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -122,12 +122,20 @@

describe 'polymorphism' do
it 'inner joins' do
if ActiveRecord::VERSION::STRING >= '5.2.0'
pending "polyamorous's support for polymorphism is broken"
end

relation = Picture.joining { imageable.of(Post) }

expect(relation).to match_sql_snapshot
end

it 'outer joins' do
if ActiveRecord::VERSION::STRING >= '5.2.0'
pending "polyamorous's support for polymorphism is broken"
end

relation = Picture.joining { imageable.of(Post).outer }

expect(relation).to match_sql_snapshot
Expand Down Expand Up @@ -156,6 +164,10 @@
end

it 'handles polymorphism' do
if ActiveRecord::VERSION::STRING >= '5.2.0'
pending "polyamorous's support for polymorphism is broken"
end

relation = Picture.joining { imageable.of(Post).comments }

expect(relation).to match_sql_snapshot
Expand Down
8 changes: 8 additions & 0 deletions spec/integration/where_chain_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,10 @@
end

it 'wheres on polymorphic associations' do
if ActiveRecord::VERSION::STRING >= '5.2.0'
pending "polyamorous's support for polymorphism is broken"
end

relation = Picture.joining { imageable.of(Post) }.where.has {
imageable.of(Post).title =~ 'meatloaf'
}
Expand All @@ -78,6 +82,10 @@
end

it 'wheres on polymorphic associations outer join' do
if ActiveRecord::VERSION::STRING >= '5.2.0'
pending "polyamorous's support for polymorphism is broken"
end

relation = Picture.joining { imageable.of(Post).outer }.where.has {
imageable.of(Post).title =~ 'meatloaf'
}
Expand Down

0 comments on commit 34e07ba

Please sign in to comment.