Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merlin Manager x Merlin Monitor Integration #2

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

bgunnar5
Copy link

This branch will have the merlin monitor functionality handled by the merlin manager. It will also have the suggested changes that I commented on in LLNL#489.

@bgunnar5
Copy link
Author

@ryannova do we want to have celery worker entries deleted from the redis database when we stop workers? I'm worried that for redis servers not hosted by the container (i.e. LaunchIT) we'll end up having way too many worker entries over a long period of time.

If we don't want to delete the celery worker keys when we stop the workers then maybe we want a command like merlin manager remove-workers that does this for the user? Then again, this just seems like one more thing for the user to keep track of which I'd like to avoid if possible.

@bgunnar5 bgunnar5 marked this pull request as ready for review August 29, 2024 22:27
@bgunnar5
Copy link
Author

Marking this as ready for review but haven't done the merlin monitor -> merlin manager changes yet. This just has the changes suggested in LLNL#489.

@ryannova ryannova merged commit 9020aa0 into ryannova:celerymanager Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants