Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not collect disks with si #267

Closed
wants to merge 1 commit into from

Conversation

akoptelov
Copy link
Contributor

@akoptelov akoptelov commented Nov 14, 2023

I didn't find anything that might be missing if System::new() is used instead of System::new_all().

See new() vs new_all()

Fix: #266

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e297324) 97.76% compared to head (6fb932a) 97.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
+ Coverage   97.76%   97.94%   +0.18%     
==========================================
  Files          24       24              
  Lines        1609     1609              
==========================================
+ Hits         1573     1576       +3     
+ Misses         36       33       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CraZySacX
Copy link
Member

CraZySacX commented Jan 12, 2024

I like this idea, but I think we need to make it configurable. Using new() by itself on the latest version of sysinfo shouldn't query the disks anymore. There is a new Disks interface that takes care of that which currently isn't being used.

I'll create a PR from this one and make the refresh configurable to make this feature more flexible.

@CraZySacX CraZySacX force-pushed the sysinfo-no-disk-info branch from c4fa42a to 6fb932a Compare January 12, 2024 15:46
@CraZySacX
Copy link
Member

This has been implemented.

@CraZySacX CraZySacX closed this Jan 15, 2024
@akoptelov
Copy link
Contributor Author

I'll create a PR from this one and make the refresh configurable to make this feature more flexible.

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build script with vergen collecting system info might take a lot of time
2 participants