Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fruity advisory for nvzqz/fruity#14 #1102

Merged
merged 4 commits into from
Nov 15, 2021
Merged

Add fruity advisory for nvzqz/fruity#14 #1102

merged 4 commits into from
Nov 15, 2021

Conversation

dylni
Copy link
Contributor

@dylni dylni commented Nov 14, 2021

Issue: nvzqz/fruity#14

A CVE request has been submitted as well.

Questions:

@Shnatsel
Copy link
Member

Thank you for the report!

Could you clarify why this presents a security issue, ideally in the advisory text?
It does appear to be a logic bug, but I don't see any evidence of memory corruption or the like.

@dylni
Copy link
Contributor Author

dylni commented Nov 14, 2021

@Shnatsel An impact section has now been added. Does it seem sufficient?

This is easily one of the less severe security issues in many cases, since there are usually other mitigations that would prevent it. However, it was one of the main criticisms of PHP, for instance, so it has caused issues for filename validation in the past:
https://www.php.net/manual/en/security.filesystem.nullbytes.php

@Shnatsel
Copy link
Member

Yes, the Impact section looks very well-written to me. Merging.

And thank you very much for discovering and reporting the issue!

@Shnatsel Shnatsel merged commit d5184e3 into rustsec:main Nov 15, 2021
@dylni
Copy link
Contributor Author

dylni commented Nov 15, 2021

Thanks @Shnatsel!

Should I create an issue to ask if the crate is no longer maintained, or is nvzqz/fruity#13 sufficient?

Also, the affected.functions section does not include the affected traits (e.g., Display). Is there a way to include those as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants