Make room for additional revocation strategies. #209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for support of additional revocation checking strategies, first one being support for OCSP stapling.
* `CrlsRequired` has been generalized to `InadequateStrategy(&'static str)` The `Copy` derive has for that reason been removed. * Removed the private `CertNotRevoked::assertion()` constructor in favor of construction by `CertRevoked(())`. It's simply for the sake of keeping things consistent with the other result markers.
The goal is to ease identification and management components that can be used for other strategies.
Have check() return `Result<RevocationStatus, Error>`. Previous `Result<Option<CertNotRevoked>, Error>` returning `Ok(None)` doesn't convey much for how/if the caller should handle such function results. This should hopefully be less ambiguous now that it instead returns `Ok(RevocationStatus::Skipped)`.
Otherwise, it becomes possible to easily circumvent the strategy adequacy verification done by the builder.
Makes it's done in `CertRevocationList::verify_signature()` and not in the `RevocationVerifier` implementation.
|
Thanks for submitting this! Looks like you've taken care to build a clean commit history, but I'm not sure we have resources in the near future to closely review or finish this. As such, I'll close this, but we'd be happy for anyone who wants to pick this back up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have to unfortunately move on to other things, but posting this as a draft anyways, in case someone wants to pick up the work. (Also ok with it being immediately closed.)
The commits are by themselves fairly descriptive and probably give a better summary than anything I could write up here.
The next step for me towards rustls/rustls#1541 was to make an attempt at initial revocation configuration support in
rustls, possibly letting the client config pass down CLRs. Then implementing OCSP response checking inwebpkionly once I got a better understanding of how they would be passed on fromrustls.I probably won't be resolving any review suggestions.
All the best ✌️