Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename OPENDAL_HOT_*/COLD_* to OPENDALHOT_*/COLD_* #1393

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aawsome
Copy link
Member

@aawsome aawsome commented Jan 2, 2025

#1392 was unfortunately ambiguous. IMO the better option to solve #1391 is to use OPENDALHOT_* and OPENDALCOLD_* env variables.

@simonsan
Copy link
Contributor

simonsan commented Jan 3, 2025

Wouldn't it be more consistent to use RUSTIC_OPENDAL_* to make it less ambigious and also people can relate the env var to rustic?

@aawsome
Copy link
Member Author

aawsome commented Jan 26, 2025

It is actually a bit complicated. The opendal project also uses OPENDAL_* variables in their own CLI (I think they call it oli), so it might be beneficial to also use those. Besides this, you are right that most env variables we use start with RUSTIC_* - however, these are all the ones where we have a CLI option which is replaced by this. Here we define options which are not exposed as CLI parametes, but only within the config profile..

Anyway, the amiguity if OPENDA_HOT_XXX=YYY should be interpreted as the parameter xxx=yyy for a hot repo repo (which we want here) or as hot_xxx=yyy for hot/cold part (which is what is used without this PR) must be solved, IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants