Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update license to BSD-3-Clause #167

Merged
merged 1 commit into from
Sep 20, 2022
Merged

update license to BSD-3-Clause #167

merged 1 commit into from
Sep 20, 2022

Conversation

andreeaflorescu
Copy link
Member

As per the discussion in: #161

Before merging this, please wait for approvals from stakeholders:

  • Intel
  • Alibaba
  • Red Hat
  • Other?

Summary of the PR

Please summarize here why the changes in this PR are needed.

Requirements

Before submitting your PR, please make sure you addressed the following
requirements:

  • All commits in this PR are signed (with git commit -s), and the commit
    message has max 60 characters for the summary and max 75 characters for each
    description line.
  • All added/changed functionality has a corresponding unit/integration
    test.
  • Any newly added unsafe code is properly documented.

@andreeaflorescu andreeaflorescu mentioned this pull request Aug 11, 2022
Open
rbradford
rbradford previously approved these changes Aug 11, 2022
View reviewed changes
jiangliu
jiangliu previously approved these changes Sep 15, 2022
View reviewed changes
@stefano-garzarella
Copy link
Member

@bonzini @haraldh I approved this PR for Red Hat changes.
Would be nice if we can have an ack from you since you contributed on this crate.

haraldh
haraldh previously approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@haraldh haraldh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LICENSE-APACHE got removed ... does it need a new LICENSE file then?

@stefano-garzarella
Copy link
Member

LICENSE-APACHE got removed ... does it need a new LICENSE file then?

@haraldh LICENSE-BSD-3-Clause is remaining in the repo, so IIUC it should be fine.

@andreeaflorescu
update license to BSD-3-Clause
35b8b77 
As per the discussion in:
rust-vmm#161

Signed-off-by: Andreea Florescu <fandree@amazon.com>
@andreeaflorescu
Copy link
Member Author

I had to do a rebase to fix the conflicts, @jiangliu @rbradford @stefano-garzarella @haraldh can you re-approve. Thanks!

@andreeaflorescu andreeaflorescu merged commit 65da1b5 into rust-vmm:main Sep 20, 2022
@andreeaflorescu andreeaflorescu deleted the update_license branch September 20, 2022 15:19
@andreeaflorescu andreeaflorescu mentioned this pull request Mar 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haraldh haraldh haraldh approved these changes

@rbradford rbradford rbradford approved these changes

@jiangliu jiangliu jiangliu approved these changes

@stefano-garzarella stefano-garzarella stefano-garzarella approved these changes

@sameo sameo Awaiting requested review from sameo sameo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andreeaflorescu @stefano-garzarella @haraldh @rbradford @jiangliu