fix(access): properly seal access traits #59
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, anyone could just implement
Access
,Readable
,Copyable
, andCopyable
because_private()
was already available as default implementation, removing the need to construct_Private
(impossible because of#[non_exhaustive]
).This PR properly seals the affected traits as described in the Rust API Guidelines: Sealed traits protect against downstream implementations (C-SEALED)—Future proofing—Rust API Guidelines.
While this is a soundness issue, I don't think this is yank-worthy.
Note that
_private
was not hidden in the docs, so removing that would be a breaking change, strictly speaking, but I doubt that this is a problem in practice.