Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove useless condition #581

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

marcoieni
Copy link
Member

No description provided.

@marcoieni marcoieni merged commit 2c6706d into master Sep 26, 2024
3 checks passed
@marcoieni marcoieni deleted the chore-remove-useless-condition branch September 26, 2024 12:15
@shepmaster
Copy link
Member

For future context...

My guess is that when starting from a totally fresh installation there isn't an OS user called shep. Therefore the aws command to add the SSH key has permissions to run and "succeeds", but does nothing useful.

The correct command is

aws ec2-instance-connect send-ssh-public-key [...] --instance-os-user 'ubuntu' [...]

Followed by a

./apply prod [...] -u ubuntu

@marcoieni
Copy link
Member Author

thanks, I wrote this in #582

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants