chore(rustc-perf): update aws terraform provider from 3.59 to 4.67

[marcoieni]

No description provided.

[jdno]

As discussed last week, let's try to create a aws_cloudfront_response_headers_policy and see what diff Terraform will produce. 🙂

[marcoieni]

plan:

# aws_cloudfront_response_headers_policy.response_policy will be created
  + resource "aws_cloudfront_response_headers_policy" "response_policy" {
      + comment = "Policy for RustcPerf website"
      + etag    = (known after apply)
      + id      = (known after apply)
      + name    = "RustcPerfPolicy"

      + security_headers_config {
          + content_type_options {
              + override = true
            }
          + frame_options {
              + frame_option = "DENY"
              + override     = true
            }
          + referrer_policy {
              + override        = true
              + referrer_policy = "no-referrer"
            }
          + xss_protection {
              + mode_block = true
              + override   = true
              + protection = true
            }
        }
    }

  # module.static_website.aws_cloudfront_distribution.website will be updated in-place
  ~ resource "aws_cloudfront_distribution" "website" {
      ~ http_version                   = "http2" -> "http2and3"
        id                             = "E355NZKQL79WTL"
        tags                           = {}
        # (19 unchanged attributes hidden)

      ~ default_cache_behavior {
          + cache_policy_id            = "658327ea-f89d-4fab-a63d-7e88639e58f6"
          + response_headers_policy_id = (known after apply)
            # (11 unchanged attributes hidden)

          - forwarded_values {
              - headers                 = [] -> null
              - query_string            = false -> null
              - query_string_cache_keys = [] -> null

              - cookies {
                  - forward           = "none" -> null
                  - whitelisted_names = [] -> null
                }
            }
        }

      ~ viewer_certificate {
          ~ minimum_protocol_version       = "TLSv1" -> "TLSv1.2_2021"
            # (3 unchanged attributes hidden)
        }

        # (2 unchanged blocks hidden)
    }

Plan: 1 to add, 1 to change, 0 to destroy.
╷
│ Warning: Argument is deprecated
│
│   with aws_s3_bucket.bucket,
│   on s3.tf line 86, in resource "aws_s3_bucket" "bucket":
│   86: resource "aws_s3_bucket" "bucket" {
│
│ Use the aws_s3_bucket_versioning resource instead
│
│ (and 5 more similar warnings elsewhere)
╵

[marcoieni]

I had to add this field because it's required now

[marcoieni]

@Kobzol does the policy I added look reasonable?
How can I make sure nothing breaks after I deploy this change?

I would like to understand and document how perf-data.rust-lang.org is used 👍

[Kobzol]

How can I make sure nothing breaks after I deploy this change?

You wait until you hear from angry users 😆 The way the collector talks to the website, and how it's all wired up, is a bit brittle.

I wrote a high-level description on my blog (https://kobzol.github.io/rust/rustc/2023/08/18/rustc-benchmark-suite.html). The database is somehow documented here. The rest is a set of invariants hidden within the source code of rustc-perf.

[Kobzol]

Wait, perf-data.rust-lang.org? I actually have no idea what that is. I thought that you're talking about perf.rust-lang.org :)

[marcoieni]

it's used in rustc-perf: https://github.com/search?q=repo%3Arust-lang%2Frustc-perf%20perf-data.rust-lang.org&type=code

[Kobzol]

Right, I asked Mark and he explained stuff to me, as always. It is used to download self-profile results from S3, mostly (and also manually uploaded DB dumps).

[marcoieni]

Ok, thanks! I'll merge and apply this PR. hopefully there will be no angry users 😁

[marcoieni]

I just applied. Let me know if there's any issue