Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitoring: Remove obsolete "cratesio/SlowDownloads" alerting rule #404

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Apr 10, 2024

The crate downloads are no longer going through the crates.io API. Since this alerting rule is based on the crates.io API traffic, it no longer serves its purpose. Whether we can implement something similar based on the CDN traffic logs would probably have to be figured out by the infra team 😅

The crate downloads are no longer going through the crates.io API. Since this alerting rule is based on the crates.io API traffic, it no longer serves its purpose. Whether we can implement something similar based on the CDN traffic logs would probably have to be figured out by the infra team 😅
@Turbo87
Copy link
Member Author

Turbo87 commented Apr 18, 2024

r? @rust-lang/infra

Copy link
Member

@jdno jdno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the rule. 👍 But if we need to recreate it based on the logs, we should create a tracking issue. Otherwise we'll forgot.

@Turbo87
Copy link
Member Author

Turbo87 commented Apr 18, 2024

I expect us to revisit the whole alerting situation once DataDog is fully operational with the whole team having access. I guess the "slow" downloads was primarily relevant for the previous situation where such an alert was actionable. We will have to see what alerts will make sense in the future.

@jdno jdno merged commit d66bd4e into rust-lang:master Apr 19, 2024
3 checks passed
@jdno
Copy link
Member

jdno commented Apr 19, 2024

I ran Ansible and the alert has been removed from Prometheus. :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants