Code

Retire ItemLikeVisitor trait#96825

Code

Merged

bors merged 30 commits intorust-lang:masterrust-lang/rust:masterfrom kckeiks:remove-item-like-visitor-traitkckeiks/rust:remove-item-like-visitor-traitCopy head branch name to clipboardMay 17, 2022

+640-791

Commits

Commits on May 13, 2022

• Remove CheckConstTraitVisitor

  Show description for bd2b210
  kckeiks

  committed
  bd2b210

  Copy full SHA for bd2b210

• replace usage of visit_item_likes_in_modules with hir_module_items query

  Show description for 0026034
  kckeiks

  committed
  0026034

  Copy full SHA for 0026034

• remove LifeSeeder

  Show description for 52f833a
  kckeiks

  committed
  52f833a

  Copy full SHA for 52f833a

• remove DiagnosticItemCollector

  Show description for dab0e75
  kckeiks

  committed
  dab0e75

  Copy full SHA for dab0e75

• remove ItemLikeVisitor impl for EntryContext

  Show description for fb73ae2
  kckeiks

  committed
  fb73ae2

  Copy full SHA for fb73ae2

• optimize find_item to fetch Item only when needed

  Show description for b1f0209
  kckeiks

  committed
  b1f0209

  Copy full SHA for b1f0209

• remove OuterVisitor

  Show description for 0ef16fe
  kckeiks

  committed
  0ef16fe

  Copy full SHA for 0ef16fe

• remove LayoutTest

  Show description for 45c37da
  kckeiks

  committed
  45c37da

  Copy full SHA for 45c37da

• remove CollectPrivateImplItemsVisitor

  Show description for 0a029e2
  kckeiks

  committed
  0a029e2

  Copy full SHA for 0a029e2

• check def_kind before fetching item

  Show description for 90685c6
  kckeiks

  committed
  90685c6

  Copy full SHA for 90685c6

• replace hir().def_kind for def_kind query in rustc_passes

  Show description for eea16de
  kckeiks

  committed
  eea16de

  Copy full SHA for eea16de

• remove TraitVisitor

  Show description for e8ef5bf
  kckeiks

  committed
  e8ef5bf

  Copy full SHA for e8ef5bf

• remove Visitor impl for PrivateItemsInPublicInterfacesChecker

  Show description for e166409
  kckeiks

  committed
  e166409

  Copy full SHA for e166409

• add module_items

  Show description for cdba1dc
  kckeiks

  committed
  cdba1dc

  Copy full SHA for cdba1dc

• remove TestItemNamesVisitor

  Show description for 52d721c
  kckeiks

  committed
  52d721c

  Copy full SHA for 52d721c

• remove DebuggerVisualizerCollector

  Show description for 885b90b
  kckeiks

  committed
  885b90b

  Copy full SHA for 885b90b

• remove HirVisitor

  Show description for 0b7dd95
  kckeiks

  committed
  0b7dd95

  Copy full SHA for 0b7dd95

• remove ItemLikeVisitor and DeepVisitor

  Show description for 93616dd
  kckeiks

  committed
  93616dd

  Copy full SHA for 93616dd

• update comments about visitor strategy

  Show description for 7e44078
  kckeiks

  committed
  7e44078

  Copy full SHA for 7e44078

• rename visit item-like methods

  Show description for f975d05
  kckeiks

  committed
  f975d05

  Copy full SHA for f975d05

• change back to using tcx.hir() visit-item method

  Show description for 2e98879
  kckeiks

  committed
  2e98879

  Copy full SHA for 2e98879

• update rustdoc code to use new method name

  Show description for cad1fd2
  kckeiks

  committed
  cad1fd2

  Copy full SHA for cad1fd2

• change for_each_module's parameter to FnMut

  Show description for df11942
  kckeiks

  committed
  df11942

  Copy full SHA for df11942

• use for_each_module instead of iterating over Item's

  Show description for 91223ac
  kckeiks

  committed
  91223ac

  Copy full SHA for 91223ac

• avoid converting to DefId from LocalDefId when using query

  Show description for 433a5f1
  kckeiks

  committed
  433a5f1

  Copy full SHA for 433a5f1

• remove unnecessary methods from HirIdValidator

  Show description for 17e86d9
  kckeiks

  committed
  17e86d9

  Copy full SHA for 17e86d9

• remove redundant branch

  Show description for f1c256d
  kckeiks

  committed
  f1c256d

  Copy full SHA for f1c256d

Commits on May 14, 2022

• avoid fetching HIR when handling Impl assoc items

  Show description for 959636d
  kckeiks

  committed
  959636d

  Copy full SHA for 959636d

• use opt_item_name to pattern match items with names

  Show description for f77658b
  kckeiks

  committed
  f77658b

  Copy full SHA for f77658b

• allocate string only when error will be emitted

  Show description for 48fd666
  kckeiks

  committed
  48fd666

  Copy full SHA for 48fd666