Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update clippy #64810

Closed
wants to merge 1 commit into from
Closed

Update clippy #64810

wants to merge 1 commit into from

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Sep 26, 2019

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 26, 2019
@Manishearth
Copy link
Member

@bors r+ p=2

@bors
Copy link
Contributor

bors commented Sep 26, 2019

📌 Commit 24fedb9 has been approved by Manishearth

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 26, 2019
@matthiaskrgr
Copy link
Member

should this wait until after #64515 lands?
otherwise clippy might break immediately again and we wasted 3-4 hours of ci time

@Manishearth
Copy link
Member

@bors r-

yeah, i kinda assumed that had landed already

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 26, 2019
@pnkfelix pnkfelix mentioned this pull request Sep 26, 2019
Closed
@tesuji tesuji deleted the clippyup branch September 27, 2019 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clippy-driver no longer builds after rust-lang/rust#64513
6 participants
@tesuji @rust-highfive @Manishearth @bors @matthiaskrgr @oli-obk