Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] avoid to_region_vid ICE during constraint conversion #58839

Closed
wants to merge 2 commits into from
Closed

[WIP] avoid to_region_vid ICE during constraint conversion #58839

wants to merge 2 commits into from

Conversation

pnkfelix
Copy link
Member

@pnkfelix pnkfelix commented Mar 1, 2019 •
edited
Loading

Cc #57464

pnkfelix added 2 commits March 1, 2019 13:34
@pnkfelix
Avoid ICE by using delay_span_bug on constraint_conversion's to_regio…
9f75f51 
…n_vid calls.

(required slight revision to to_region_vid to return Result.)
@pnkfelix
Unit tests for rust-lang#57464 ICE.
88801bf
@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 1, 2019
@pnkfelix
Copy link
Member Author

pnkfelix commented Mar 1, 2019

r? @matthewjasper

@pnkfelix pnkfelix mentioned this pull request Mar 1, 2019
Closed
@matthewjasper
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Mar 1, 2019

📌 Commit 88801bf has been approved by matthewjasper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 1, 2019
@matthewjasper
Copy link
Contributor

@bors r- this does not appear to fully fix the problem. See #57464 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 2, 2019
@pnkfelix
Copy link
Member Author

pnkfelix commented Mar 4, 2019

@matthewjasper That's unfortunate.

What do you think about landing this anyway? I'm removing "fix" from the description.

@pnkfelix
Copy link
Member Author

pnkfelix commented Mar 4, 2019

Cc @nikomatsakis

@matthewjasper
Copy link
Contributor

I'm not sure, landing a partial fix that makes the code more complicated doesn't seem like such a great idea.

@pnkfelix pnkfelix changed the title avoid to_region_vid ICE during constraint conversion [WIP] avoid to_region_vid ICE during constraint conversion Mar 11, 2019
@pnkfelix
Copy link
Member Author

I'm going to close this and see if I can attack the root problem.

@pnkfelix pnkfelix closed this Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matthewjasper matthewjasper

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pnkfelix @rust-highfive @matthewjasper @bors @petrochenkov