Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Resolve nested impl Traits #50419

Merged
merged 1 commit into from
May 5, 2018
Merged

rustdoc: Resolve nested impl Traits #50419

merged 1 commit into from
May 5, 2018

Conversation

sinkuu
Copy link
Contributor

@sinkuu sinkuu commented May 3, 2018

Fixes #50358.

Populates cx.impl_trait_bounds incrementally while cleaning generic params, so that a synthetic type-parameter can refer to previous ones.

cc #50366

@rust-highfive
Copy link
Collaborator

r? @frewsxcv

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 3, 2018
@sinkuu sinkuu force-pushed the rustdoc_nested_impl_trait branch from 1b1560e to 14f32f6 Compare May 3, 2018 13:34
@GuillaumeGomez
Copy link
Member

Way better! Thanks for it! :)

@QuietMisdreavus QuietMisdreavus mentioned this pull request May 4, 2018
Closed
@pietroalbini pietroalbini added the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 4, 2018
@QuietMisdreavus
Copy link
Member

I like this! Thanks so much for posting the fix!

@bors r+

@bors
Copy link
Contributor

bors commented May 4, 2018

📌 Commit 14f32f6 has been approved by QuietMisdreavus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2018
@pietroalbini
Copy link
Member

Can we get this into beta?

@bors
Copy link
Contributor

bors commented May 5, 2018

⌛ Testing commit 14f32f6 with merge 5d6c757...

bors added a commit that referenced this pull request May 5, 2018
@bors
Auto merge of #50419 - sinkuu:rustdoc_nested_impl_trait, r=QuietMisdr…
5d6c757 
…eavus

rustdoc: Resolve nested `impl Trait`s

Fixes #50358.

Populates `cx.impl_trait_bounds` incrementally while `clean`ing generic params, so that a synthetic type-parameter can refer to previous ones.

cc #50366
@bors
Copy link
Contributor

bors commented May 5, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: QuietMisdreavus
Pushing 5d6c757 to master...

@bors bors merged commit 14f32f6 into rust-lang:master May 5, 2018
@bors bors mentioned this pull request May 5, 2018
Merged
@pietroalbini pietroalbini mentioned this pull request May 6, 2018
Merged
@alexcrichton alexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label May 6, 2018
@pietroalbini pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 6, 2018
bors added a commit that referenced this pull request May 6, 2018
@bors
Auto merge of #50478 - pietroalbini:beta-backports, r=kennytm
1ac15ac 
[beta] Process backports

* #50419: rustdoc: Resolve nested `impl Trait`s
* #50474: Fix ICE in assertion macro

r? @Mark-Simulacrum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@QuietMisdreavus QuietMisdreavus

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sinkuu @rust-highfive @GuillaumeGomez @QuietMisdreavus @bors @pietroalbini @alexcrichton @frewsxcv