Rollup of 10 pull requests #137130
Closed
Rollup of 10 pull requests #137130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should give us some performance improvements as we won't need to do the lookup for the _currently_ 287 targets we have.
Signed-off-by: onur-ozkan <work@onurozkan.dev>
It uses the file metadata on Unix with a fallback for files incorrectly reported as zero-sized. It uses `GetFileSizeEx` on Windows. This reduces the number of syscalls needed for determining the file size of an open file from 3 to 1.
It can only describe the inner workings of the default implementation, other implementations might not be implemented using seeks at all.
…plett Optimize `Seek::stream_len` impl for `File` It uses the file metadata on Unix with a fallback for files incorrectly reported as zero-sized. It uses `GetFileSizeEx` on Windows. This reduces the number of syscalls needed for determining the file size of an open file from 3 to 1.
…-test-cc-detect, r=onur-ozkan add docs and ut for bootstrap util cc-detect This PR adds doc and unit test for bootstrap utils/cc-detect module
…nce, r=Noratrieb Load all builtin targets at once instead of one by one in check-cfg This PR adds a method on `rustc_target::Target` to load all the builtin targets at once, and then uses that method when constructing the `target_*` values in check-cfg instead of load loading each target one by one by their name, which requires a lookup and was more of a hack anyway. This may give us some performance improvements as we won't need to do the lookup for the _currently_ 287 targets we have.
bootstrap: add more tracing to compiler/std/llvm flows
- Add more tracing to compiler/std/llvm flows.
- Two drive-by nits:
1. Take `TargetSelection` by-value for `builder.is_builder_target()`. Noticed while adding tracing; follow-up to rust-lang#136767.
2. Coalesce enzyme build logic into one branch.
- Document `COMPILER{,_FOR}` tracing targets for rust-lang#96176.
- No functional changes.
### Testing
You can play with the tracing locally with:
```
$ BOOTSTRAP_TRACING=bootstrap=debug ./x build library
$ BOOTSTRAP_TRACING=bootstrap=trace ./x build library
$ BOOTSTRAP_TRACING=bootstrap=trace,COMPILER=trace,COMPILER_FOR=trace ./x build library
```
### Previews
```
$ BOOTSTRAP_TRACING=bootstrap=debug ./x build library
```
```
$ BOOTSTRAP_TRACING=bootstrap=trace,COMPILER=trace,COMPILER_FOR=trace ./x build library
```
r? `@onur-ozkan` (or reroll)
…li-obk Rework `name_regions` to not rely on reverse scc graph for non-member-constrain usages Fixes rust-lang#137015 Splits the `name_regions` into two versions: One meant for member region constraint error reporting (which I've renamed to `name_regions_for_member_constraint`), and one meant *just* to replace region vids with an external region. Use the latter in the usage sites I added in rust-lang#136559, since the regions returned by `name_regions_for_member_constraint` are also not *totally* accurate (which is fine for how they're used for member region constraint error reporting -- they're intentionally returning overapproximated universal regions so that we have something to name in `+ use<'a>` suggestions, because opaques can only capture universal regions and since member region constraints don't insert any edges into the region graph, the error region is probably gonna be shorter than a universal region) and because that function requires the reverse scc graph to have been computed which isn't done for our usages in rust-lang#136559.
…ct, r=oli-obk Don't project into `NonNull` when dropping a `Box` Another step towards banning these projections. Tracking Issue rust-lang#133652
Add an example for `std::error::Error` There is currently no example provided for `std::error::Error` so let's fix that.
…oratrieb Fix test that relies on error language We shouldn't care about the OS error message text in this test.
…ouxu
fix broken `x {doc, build} core`
Fixes rust-lang#137115
…illaumeGomez Enable `relative-path-include-bytes-132203` rustdoc-ui test on Windows The problem with the error message on Windows is: - The path separators are different - The OS error message string is different Normalizing those two things makes the test pass on Windows.
rustbot
added
A-rustc-dev-guide
rustbot
added
O-windows
|
@bors r+ p=5 rollup=never |
bors
added
S-waiting-on-bors
|
overlaps with #137124 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Seek::stream_lenimpl forFile#125087 (OptimizeSeek::stream_lenimpl forFile)name_regionsto not rely on reverse scc graph for non-member-constrain usages #137102 (Reworkname_regionsto not rely on reverse scc graph for non-member-constrain usages)NonNullwhen dropping aBox#137112 (Don't project intoNonNullwhen dropping aBox)std::error::Error#137114 (Add an example forstd::error::Error)x {doc, build} core#137119 (fix brokenx {doc, build} core)relative-path-include-bytes-132203rustdoc-ui test on Windows #137120 (Enablerelative-path-include-bytes-132203rustdoc-ui test on Windows)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup