Implement Extend<AsciiChar> for String #136749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
Oops, sorry I missed the first ping. Thanks for making this! @bors r+ rollup=always |
|
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
7 tasks
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 15, 2025
Rollup of 9 pull requests Successful merges: - rust-lang#135687 (re-export `FromCoroutine` from `core::iter`) - rust-lang#135813 (CI: split i686-mingw job to three free runners) - rust-lang#136749 (Implement Extend<AsciiChar> for String) - rust-lang#136879 (Add safe new() to NotAllOnes) - rust-lang#136978 (Windows: Update generated bindings) - rust-lang#137028 (mir_build: Clarify some code for lowering `hir::PatExpr` to THIR) - rust-lang#137029 (Remove unnecessary check code in unused_delims) - rust-lang#137056 (made check_argument_compat public for use in miri) - rust-lang#137062 (Forward all default methods for I/O impls) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 15, 2025
Rollup merge of rust-lang#136749 - mzeitlin11:extend-asciichar, r=scottmcm Implement Extend<AsciiChar> for String Implement `Extend<AsciiChar>` for `String` as suggested in rust-lang#110998 (comment). Also implements `Extend<&AsciiChar>` since there's an analogous impl for `Extend<&char>`, but happy to remove if not thought useful. r? `@scottmcm` since you requested it, but no pressure to review!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
Extend<AsciiChar>forStringas suggested in #110998 (comment). Also implementsExtend<&AsciiChar>since there's an analogous impl forExtend<&char>, but happy to remove if not thought useful.r? @scottmcm
since you requested it, but no pressure to review!