Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider inner modules to be local in the non_local_definitions lint #124539

Merged
merged 1 commit into from
May 1, 2024
Merged

Consider inner modules to be local in the non_local_definitions lint #124539

merged 1 commit into from
May 1, 2024

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented Apr 29, 2024 •
edited
Loading

This PR implements the proposed fix for #124396, that is to consider inner modules to be local in the non_local_definitions lint.

This PR is voluntarily kept as minimal as possible so it can be backported easily.

T-lang nomination will need to be removed before this can be merged.

Fixes (nearly, needs backport) #124396

@rustbot
Copy link
Collaborator

rustbot commented Apr 29, 2024

r? @compiler-errors

rustbot has assigned @compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 29, 2024
@compiler-errors
Copy link
Member

r? lcnr

@rustbot rustbot assigned lcnr and unassigned compiler-errors Apr 29, 2024
@lcnr
Copy link
Contributor

lcnr commented May 1, 2024

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 1, 2024

📌 Commit 21c688a has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 1, 2024
@bors
Copy link
Contributor

bors commented May 1, 2024

⌛ Testing commit 21c688a with merge 378a43a...

@bors
Copy link
Contributor

bors commented May 1, 2024

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing 378a43a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 1, 2024
@bors bors merged commit 378a43a into rust-lang:master May 1, 2024
10 checks passed
@rustbot rustbot added this to the 1.80.0 milestone May 1, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (378a43a): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 673.742s -> 672s (-0.26%)
Artifact size: 315.92 MiB -> 315.97 MiB (0.01%)

@Urgau
Copy link
Member Author

Urgau commented May 1, 2024

Nominating this PR for beta backport, as the non_local_definitions lint is warn-by-default in beta 1.79 and #124396 is reporting the issue on beta with the diesel crate

@rustbot label +beta-nominated

@rustbot rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 1, 2024
@apiraino apiraino mentioned this pull request May 2, 2024
Closed
@apiraino
Copy link
Contributor

apiraino commented May 3, 2024

Beta backport accepted as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle.

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label May 3, 2024
@cuviper cuviper mentioned this pull request May 9, 2024
Merged
@cuviper cuviper modified the milestones: 1.80.0, 1.79.0 May 9, 2024
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 9, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request May 10, 2024
@bors
Auto merge of rust-lang#124947 - cuviper:beta-next, r=cuviper
a269819 
[beta] backports

- Consider inner modules to be local in the `non_local_definitions` lint rust-lang#124539
- Fix bootstrap panic when build from tarball rust-lang#124668

r? cuviper
@Urgau Urgau added the L-non_local_definitions Lint: non_local_definitions label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. L-non_local_definitions Lint: non_local_definitions merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.
8 participants
@Urgau @rustbot @compiler-errors @lcnr @bors @rust-timer @apiraino @cuviper