Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider move libarena and libgraphviz out of tree #63457

Closed
crlf0710 opened this issue Aug 11, 2019 · 3 comments
Closed

Consider move libarena and libgraphviz out of tree #63457

crlf0710 opened this issue Aug 11, 2019 · 3 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@crlf0710
Copy link
Member

These code doesn't get touched a lot. So maybe it makes sense to move them out instead of generating auto publish packages every day.

@jonas-schievink jonas-schievink added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 11, 2019
@matklad
Copy link
Member

matklad commented Aug 15, 2019

Note that libarena already exists out of tree as https://crates.io/crates/typed_arena, which is a well maintained and widely used crate.

@crlf0710
Copy link
Member Author

Opened thomcc/rust-typed-arena#28 .

@Mark-Simulacrum
Copy link
Member

I'm going to close this as I think doing this is best done as publishing a crate (perhaps a direct copy of in-tree code), getting the code in a state perhaps more fit for crates.io, and then using it in tree. Just copying the code to a separate repository does not seem helpful, and indeed, seems actively harmful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants