Skip to content

Commit 5dd871b

Browse files
committed
Rewrite core-no-fp-fmt-parse in Rust
Rewrite core-no-fp-fmt-parse in Rust fix: missing import fix: tidiness check more tidy checks remove tidy line length ignore new helper functions + arg_path generic
1 parent d748046 commit 5dd871b

File tree

4 files changed

+41
-5
lines changed

4 files changed

+41
-5
lines changed

src/tools/run-make-support/src/rustc.rs

+24
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
use std::env;
22
use std::path::Path;
3+
use std::path::PathBuf;
34
use std::process::{Command, Output};
45

56
use crate::{handle_failed_output, tmp_dir};
@@ -104,6 +105,29 @@ impl Rustc {
104105
self
105106
}
106107

108+
/// Generic file path provider.
109+
pub fn arg_path<P>(&mut self, path: P) -> &mut Self
110+
where
111+
P: AsRef<Path>,
112+
{
113+
self.cmd.arg(path.as_ref());
114+
self
115+
}
116+
117+
/// Specify the crate type.
118+
pub fn crate_type(&mut self, crate_type: &str) -> &mut Self {
119+
self.cmd.arg("--crate-type");
120+
self.cmd.arg(crate_type);
121+
self
122+
}
123+
124+
/// Specify the edition year.
125+
pub fn edition(&mut self, edition: &str) -> &mut Self {
126+
self.cmd.arg("--edition");
127+
self.cmd.arg(edition);
128+
self
129+
}
130+
107131
/// Generic command arguments provider. Use `.arg("-Zname")` over `.arg("-Z").arg("arg")`.
108132
/// This method will panic if a plain `-Z` or `-C` is passed, or if `-Z <name>` or `-C <name>`
109133
/// is passed (note the space).

src/tools/tidy/src/allowed_run_make_makefiles.txt

-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ run-make/compiler-rt-works-on-mingw/Makefile
3131
run-make/compressed-debuginfo/Makefile
3232
run-make/const-prop-lint/Makefile
3333
run-make/const_fn_mir/Makefile
34-
run-make/core-no-fp-fmt-parse/Makefile
3534
run-make/core-no-oom-handling/Makefile
3635
run-make/crate-data-smoke/Makefile
3736
run-make/crate-hash-rustc-version/Makefile

tests/run-make/core-no-fp-fmt-parse/Makefile

-4
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
// This test checks that the core library of Rust can be compiled without enabling
2+
// support for formatting and parsing floating-point numbers.
3+
4+
extern crate run_make_support;
5+
6+
use run_make_support::rustc;
7+
use std::path::PathBuf;
8+
9+
fn main() {
10+
rustc()
11+
.edition("2021")
12+
.arg("-Dwarnings")
13+
.crate_type("rlib")
14+
.arg_path("../../../library/core/src/lib.rs")
15+
.cfg("no_fp_fmt_parse")
16+
.run();
17+
}

0 commit comments

Comments
 (0)