Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Officially recognize carry over of cargo script #294

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

epage
Copy link
Contributor

@epage epage commented Feb 26, 2025

This was approved for 2025h2 and I figured I wouldn't bother carrying it over since so little was left but what was left was the cross-team stuff and I should have called this out.
So this is rectifying that.

Rendered

This was approved for 2025h2 and I figured I wouldn't bother carrying it
over since so little was left but what was left was the cross-team
stuff and I should have called this out.
So this is rectifying that.
@epage
Copy link
Contributor Author

epage commented Feb 26, 2025

Talked with @nikomatsakis about holding a small FCP from the relevant teams for this.

@nikomatsakis
Copy link
Contributor

I wouldn't bother with a full FCP, I think if we can get agreement from the team leads that suffices (that's the standard for the RFC, after all).

cc @rust-lang/compiler @rust-lang/lang @rust-lang/spec -- @epage wanted to do a late addition to the goals for the remaining cargo script work. Wearing my project goals coordinator hat, this seems fine to me. But teams should check whether they have any concerns about the team asks described in this document. I'll create real check boxes later for leads.

| Rust-analyzer implementation | @epage | |
| Standard reviews | ![Team][] [compiler] | |
| Lang-team champion | ![Team][] [lang] | |
| Design meeting | ![Team][] [lang] | |
Copy link
Contributor

@traviscross traviscross Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Design meeting | ![Team][] [lang] | |

I don't see that we left any open questions on the RFC. It'd surprise me if this needed a design meeting.

Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll probably also be point for the spec team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants