better help for mixed_case_hex_literals
#14235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Alexendoo rustbot has assigned @Alexendoo. Use |
rustbot
added
the
S-waiting-on-review
lapla-cogito
force-pushed
the
mixedhex_betterhelp
branch
from
37076ea to
01ee6c4
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
lapla-cogito
force-pushed
the
mixedhex_betterhelp
branch
from
01ee6c4 to
81b1987
Compare
|
I rebased onto the latest master because the Remark test failed in the merge queue, but it looks like it's failing again... |
lapla-cogito
force-pushed
the
mixedhex_betterhelp
branch
from
81b1987 to
e587a5d
Compare
|
Seems the remark CI is fixed now, could you enqueue this again? @Alexendoo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be error-prone for developers to manually change literals with mixed uppercase and lowercase letters into consistently all-lowercase or all-uppercase literals. Therefore, this lint rule should suggest alternative literals.
changelog: [
mixed_case_hex_literals]: add alternative suggestions