fix: box_syntax/pattern

[csmoe]

Closes #1412
r? @matklad

[matklad]

bors r+

Thanks!

[bors]

Build succeeded

• continuous-integration/travis-ci/push

[Robbepop]

Does this PR also introduce box syntax in the way of matching them by box patterns?
I fail to see a test for this.
Something like this:
https://github.com/Robbepop/stevia/blob/master/simplifier/src/simplifications/bool_symbolic_solver.rs#L52

[matklad]

I think https://github.com/rust-analyzer/rust-analyzer/pull/1414/files#diff-2363d5bd87246fdd9203ebd8cf0fc230R264 covers this?

…

On Wed, 19 Jun 2019 at 13:21, Hero Bird ***@***.***> wrote: Does this PR also introduce box patterns in the way of matching them by box patterns? I fail to see a test for this. Something like this: https://github.com/Robbepop/stevia/blob/master/simplifier/src/simplifications/bool_symbolic_solver.rs#L52 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1414>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AANB3M363T572OWYHV4QORLP3ICA3ANCNFSM4HZFRAHA> .

[Robbepop]

Ah got it, didn't notice it was covered by that! Thanks. :)

[csmoe]

@matklad oops...did I miss something in this method? box syntax inside "tuple"s cannot be parsed.

struct Foo(Box<i32>);
let a = Foo(box 1i32);
let b = (box 1i32, box 2i32);

[matklad]

Hm, I guess, we should add box to expr_first ?

…

On Friday, 5 July 2019, csmoe ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In crates/ra_parser/src/grammar/expressions/atom.rs <#1414 (comment)> : > @@ -507,3 +508,17 @@ fn try_block_expr(p: &mut Parser, m: Option<Marker>) -> CompletedMarker { block(p); m.complete(p, TRY_EXPR) } + +// test box_expr +// fn foo() { +// let x = box 1i32; +// } +fn box_expr(p: &mut Parser, m: Option<Marker>) -> CompletedMarker { @matklad <https://github.com/matklad> oops...did I miss something in this method? box syntax inside "tuple"s cannot be parsed. struct Foo(Box<i32>);let a = Foo(box 1i32);let b = (box 1i32, box 2i32); — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1414>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AANB3MZT23KF25QWNPVJNKTP55O77ANCNFSM4HZFRAHA> .