Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize reference of "Attribute Macro" #958

Closed
wants to merge 1 commit into from

Conversation

ETCaton
Copy link

@ETCaton ETCaton commented Feb 4, 2021

The Attributes section uses "macro attributes" but links to a section calling them "attribute macros"

The Attributes section uses "macro attributes" but links to a section calling them "attribute macros"
@JohnTitor
Copy link
Member

I'm thinking of this but I'd prefer "macro attributes" if the wording hasn't been standardized yet. Because we have a similar wording "procedural macro attributes" and if we call the earlier "attribute macros", the word order isn't consistent. @ehuss thoughts?

@petrochenkov
Copy link
Contributor

I use both depending on context - "macro attributes and other attributes" or "attribute macros and other macros".

@JohnTitor
Copy link
Member

Hmm, that makes sense, it seems to make it clearer what we talk about now. So the question now is that whether we should standardize it or not. We should do if it makes some confusion, but it doesn't seem to be a serious problem right now.

@traviscross
Copy link
Contributor

We're going to close this in favor of:

...and due to the reason that @petrochenkov mentioned, which is that there are kind of two things here depending on context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants