Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup test links #1741

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

WaffleLapkin
Copy link
Member

@WaffleLapkin WaffleLapkin commented Feb 24, 2025

this mostly fixes problems mentioned in #1710 (comment) cc @ehuss.

before #1710

2025-02-24 02:51:46+CET
2025-02-24 02:52:04+CET

master

2025-02-24 02:52:27+CET
2025-02-24 02:52:51+CET

this PR

2025-02-24 02:53:11+CET
2025-02-24 02:53:47+CET
2025-02-24 03:00:51+CET
2025-02-24 03:12:05+CET

There are still a few problems:

  1. In wide mode tests are rendered in the page margin which is fine, but awkward
  2. In narrow mode the same happens, but it makes it unusable
  3. In wide mode everything partially overlaps with the prev/next page controls which is super awkward

I have no idea how to solve any of these, so opening a fix for what I know how to fix 👍🏻

it was broken since I changed rule link display, oops.
this prevents an issue where [*] (rule link) is cut off and only *] is
shown.
@rustbot rustbot added the S-waiting-on-review Status: The marked PR is awaiting review from a maintainer label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: The marked PR is awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants