-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement chmod
and fchmod
for Unix targets
#4214
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add tests for the new functions
I've tried. Those tests would rely on |
Maybe the shim we use to read permission is unfinished and doesn't work at all even though it could work on Unix? |
Yes, according to |
9b65328
to
b9a6736
Compare
Closes #4202
I was unable to write a test because
FileMetadata
only returns mode0o100000
for the files, no permission information is provided.