Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement FreeBSD syscall _umtx_op for futex support #4209

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

LorrensP-2158466
Copy link
Contributor

@LorrensP-2158466 LorrensP-2158466 commented Feb 25, 2025

Links to #3553.

Currently This implements the WAIT and WAKE operations of the _umtx_op syscall.
Enable sync and concurrency tests in ci/ci.sh and add tests that calls _umtx_op directly.

@LorrensP-2158466
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added the S-waiting-on-review Status: Waiting for a review to complete label Feb 25, 2025
@LorrensP-2158466 LorrensP-2158466 changed the title Freebsd futex Implement _umtx_op syscall of Freebsd for futex support Feb 25, 2025
@LorrensP-2158466 LorrensP-2158466 changed the title Implement _umtx_op syscall of Freebsd for futex support Implement FreeBSD syscall _umtx_op for futex support Feb 25, 2025
@RalfJung
Copy link
Member

Thanks for the PR! We have a significant backlog currently so unfortunately it could take a while until you get a proper review, sorry.

I have not yet changed ci/ci.sh because I don't exactly know which filters to pass. Currently if I test it locally only the the tests that use libc::cpuset_getaffinity fail.

You should add sync to have it test the libstd synchronization primitives.

Also, please add a test that directly calls the FreeBSD functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Waiting for a review to complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants