Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pin-project to 1 #2228

Merged
merged 2 commits into from
Oct 14, 2020
Merged

Update pin-project to 1 #2228

merged 2 commits into from
Oct 14, 2020

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Oct 13, 2020

No description provided.

@taiki-e
Copy link
Member Author

taiki-e commented Oct 13, 2020 •
edited
Loading

This breaks undocumented MSRV (1.36) of futures/futures-util/futures-executor/futures-test with default-features = false. (documented MSRV is 1.39)
However, as said in taiki-e/pin-project#292, this should probably be fine as that is undocumented and there is a possibility of switching to pin-project-lite that requires 1.37. (I'm working on enum support for pin-project-lite (taiki-e/pin-project-lite#28), and once that is done, we can probably switch.)

@taiki-e taiki-e merged commit 67566c6 into rust-lang:master Oct 14, 2020
@taiki-e taiki-e deleted the pin-project branch October 14, 2020 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taiki-e @seanmonstar