-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add links to "features" page, and mark default features #2532
Conversation
Unless you know what the |
*
(default)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some first comments from the first test:
deffault (default)
is perhaps a little much :)- I'm not sure if all the
default
markers are correct. Example:sentry-tower
subfeature insentry
feateure
generally especially the top section with all default features is a little noisy, I'm not sure how this could be improved, and would merge as-is when not buggy.
We still need a visual marker to make it obvious that it's not part of the feature name, hence why I suggested parens. Without parens, we then need some styling. |
@GuillaumeGomez currently it looks roughly like this: ![]() do you mean something else? |
The
|
I marked this as draft as I will iterate on this a bit more. |
this would be super awesome! |
bba0a55
to
9b07432
Compare
(default)
It took a while until I got some more time to work on this. Now this should be fairly complete with interlinks to all the own features, dependencies and features of dependencies. See the screenshot in the updated PR description. |
3e25c50
to
4919a5e
Compare
first manual test: this is beautiful :) |
f941d6e
to
317459f
Compare
This adds links to all the features, dependencies, and dependency features for easy navigation. It also marks all the transitive features with a `(default)` marker. I changed that so the secondary sort order is alphabetic, as that might make more sense than sorting by number of sub-features.
317459f
to
6d4a02e
Compare
this is really awesome :) ( I'll be offline / on a trip for next week, I'll deploy this the week after ) |
{%- if !feature.subfeatures.is_empty() -%} | ||
<ul class="pure-menu-list"> | ||
{%- for (name, feature) in feature.subfeatures -%} | ||
{%- let is_default = self.is_default_feature(name) -%} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{%- let is_default = self.is_default_feature(name) -%} | |
{%- let is_default = is_default_feature(name) -%} |
(just nitpicking ^^)
{{- dependency -}} | ||
</a> | ||
{% when SubFeature::DependencyFeature with {dependency, feature, optional} %} | ||
{%- let version = self.dependency_version(dependency) -%} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same, no need for self.
.
{{- feature -}} | ||
</a> | ||
{% when SubFeature::Dependency with (dependency) %} | ||
{%- let version = self.dependency_version(dependency) -%} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here too.
Gonna send a little cleanup, but it's really nitpicking. I also saw some |
This adds links to all the features, dependencies, and dependency features for easy navigation.
It also marks all the transitive features with a
(default)
marker.I changed that so the secondary sort order is alphabetic, as that might make more sense than sorting by number of sub-features.
Fixes #2530 and #2531
This was just a quick and dirty hack during RustFest impl Days, and we were discussing some more ideas related to the Features page in general.
The Features page now looks like this, with all the links being clickable: