Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch & upload source archive before trying to build #2529

Merged
merged 1 commit into from
Jun 23, 2024

Conversation

syphar
Copy link
Member

@syphar syphar commented Jun 23, 2024

Fixed #2499.

This will also make the sources available when the build fails in the fetch-step.

@syphar syphar requested a review from a team as a code owner June 23, 2024 10:55
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Jun 23, 2024
@syphar syphar marked this pull request as draft June 23, 2024 11:06
@syphar syphar removed the request for review from a team June 23, 2024 11:06
@syphar syphar marked this pull request as ready for review June 23, 2024 11:47
@GuillaumeGomez
Copy link
Member

Looks good to me, thanks! Please clean up your commit history then you can merge. :)

@syphar syphar force-pushed the move-source-archive branch from 401a61d to 8dd2f76 Compare June 23, 2024 12:13
@syphar
Copy link
Member Author

syphar commented Jun 23, 2024

Please clean up your commit history then you can merge. :)

my mistake, good catch!

@syphar syphar merged commit 9d67958 into rust-lang:master Jun 23, 2024
7 checks passed
@syphar syphar deleted the move-source-archive branch June 23, 2024 12:13
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Jun 23, 2024
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs.rs source view adds Cargo.lock files that are not the crate
2 participants