Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop length limitation for crate name & version #2510

Merged
merged 2 commits into from
Jun 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
-- this reverse migration might fail when we have other records
-- referencing releases with longer names or versions.
-- If this has to be reverted we probably would have to manually run
-- db::delete::delete_crate and db::delete::delete_version for the releases
-- and crates.
DELETE FROM crates WHERE LENGTH(name) > 255;
DELETE FROM releases WHERE LENGTH(version) > 100;

ALTER TABLE crates ALTER COLUMN name TYPE VARCHAR(255);
ALTER TABLE releases ALTER COLUMN version TYPE VARCHAR(100);
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
ALTER TABLE crates ALTER COLUMN name TYPE TEXT;
ALTER TABLE releases ALTER COLUMN version TYPE TEXT;
38 changes: 38 additions & 0 deletions src/db/add_package.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1110,4 +1110,42 @@ mod test {
Ok(())
})
}

#[test]
fn test_long_crate_name() {
async_wrapper(|env| async move {
let mut conn = env.async_db().await.async_conn().await;

let name: String = "krate".repeat(100);
let crate_id = initialize_crate(&mut conn, &name).await?;

let db_name = sqlx::query_scalar!("SELECT name FROM crates WHERE id = $1", crate_id)
.fetch_one(&mut *conn)
.await?;

assert_eq!(db_name, name);

Ok(())
})
}

#[test]
fn test_long_relaase_version() {
async_wrapper(|env| async move {
let mut conn = env.async_db().await.async_conn().await;

let crate_id = initialize_crate(&mut conn, "krate").await?;
let version: String = "version".repeat(100);
let release_id = initialize_release(&mut conn, crate_id, &version).await?;

let db_version =
sqlx::query_scalar!("SELECT version FROM releases WHERE id = $1", release_id)
.fetch_one(&mut *conn)
.await?;

assert_eq!(db_version, version);

Ok(())
})
}
}
Loading