-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional
suffix to dependency
#2406
Conversation
Looks good to me. Please add a test. |
cdcaa97
to
627873f
Compare
The test case was appended to the last commit. |
The test stuck in the GUI_test for a long time. |
Restarted the GUI test job. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for review this. I am not very good at visual design, if there is a clear design scheme, I am willing to try to improve it. |
Addressed #2397
Add
optional
suffix to dependency.