Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional suffix to dependency #2406

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Conversation

linyihai
Copy link
Contributor

@linyihai linyihai commented Feb 1, 2024

Addressed #2397

Add optional suffix to dependency.

@linyihai linyihai requested a review from a team as a code owner February 1, 2024 08:46
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Feb 1, 2024
@GuillaumeGomez
Copy link
Member

Looks good to me. Please add a test.

@linyihai linyihai force-pushed the mark-option branch 2 times, most recently from cdcaa97 to 627873f Compare February 2, 2024 02:52
@linyihai
Copy link
Contributor Author

linyihai commented Feb 2, 2024

Looks good to me. Please add a test.

The test case was appended to the last commit.

@linyihai
Copy link
Contributor Author

linyihai commented Feb 2, 2024

The test stuck in the GUI_test for a long time.

@GuillaumeGomez
Copy link
Member

Restarted the GUI test job.

Copy link
Member

@syphar syphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this improvement!

I did a manual test, and taking the fs-err example it looks like this:
grafik

I feel like the structure could be improved by having a visual distinction between the dependency groups and the "optional" test, but IMO it's fine for now.

@linyihai
Copy link
Contributor Author

I feel like the structure could be improved by having a visual distinction between the dependency groups and the "optional" test, but IMO it's fine for now.

Thank you for review this. I am not very good at visual design, if there is a clear design scheme, I am willing to try to improve it.

@syphar syphar merged commit a522135 into rust-lang:master Feb 14, 2024
12 checks passed
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Feb 14, 2024
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Feb 14, 2024
@linyihai linyihai deleted the mark-option branch February 17, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants