Embed metadata about the current page instead of reading from the ren…

…dered html
rust-lang · Mar 20, 2024 · 3f7b37b · 3f7b37b
1 parent 1ee11ec
commit 3f7b37b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 15 deletions.
diff --git a/static/index.js b/static/index.js
@@ -1,8 +1,3 @@
-function formatCrateName(crateTitleAndVersion) {
-    const stringParts = crateTitleAndVersion.split(" ", 2);
-    return stringParts[0] + ' = "' + stringParts[1] + '"';
-}
-
 (function() {
     const clipboard = document.getElementById("clipboard");
     if (clipboard) {
@@ -14,23 +9,17 @@ function formatCrateName(crateTitleAndVersion) {
             clipboard.innerHTML = resetClipboardIcon;
         }
 
-        function copyTextHandler() {
-            const crateTitleAndVersion = document.getElementById("crate-title");
-            // On rustdoc pages, we use `textTransform: uppercase`, which copies as uppercase.
-            // To avoid that, reset the styles temporarily.
-            const oldTransform = crateTitleAndVersion.style.textTransform;
-            crateTitleAndVersion.style.textTransform = "none";
-            const temporaryInput = document.createElement("input");
+        async function copyTextHandler() {
+            const metadata = JSON.parse(document.getElementById("crate-metadata").innerText)
 
+            const temporaryInput = document.createElement("input");
             temporaryInput.type = "text";
-            temporaryInput.value = formatCrateName(crateTitleAndVersion.innerText);
+            temporaryInput.value = `${metadata.name} = "${metadata.version}"`;
 
             document.body.append(temporaryInput);
             temporaryInput.select();
             document.execCommand("copy");
-
             temporaryInput.remove();
-            crateTitleAndVersion.style.textTransform = oldTransform;
 
             clipboard.textContent = "✓";
             if (resetClipboardTimeout !== null) {

diff --git a/templates/rustdoc/topbar.html b/templates/rustdoc/topbar.html
@@ -13,6 +13,14 @@
 {%- include "header/topbar_begin.html" -%}{#
 extra whitespace unremovable, need to use html tags unaffacted by whitespace T_T
 #}<ul class="pure-menu-list">
+    <script id="crate-metadata" type="application/json">
+        {# the only text that needs escaping in a <script> is `</`, none of the
+            values below can include that sequence #}
+        {
+            "name": {{ metadata.name | json_encode() | safe }},
+            "version": {{ metadata.version | json_encode() | safe }}
+        }
+    </script>
     {%- if krate -%}
         <li class="pure-menu-item pure-menu-has-children">
             <a href="#" class="pure-menu-link crate-name" title="{{ krate.description }}">